Factor out most of the say function to utils/speechSynthesis.ts #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- does not pass stenohintsonthefly to child components - it is used from globalUserSettings jotai state * src/AppRoutes.tsx: - removes stenohintsonthefly prop - removes unused stenohintsonthefly prop from Flashcards and StenoDictionary components
AppRoutes.tsx - removes own prop stenohintsonthefy
- factors out most part of the say method into a utils/speechSynthesis.ts - leaves App.this.say method with only the call to synthesizeSpeech with the custom parameters - moves the synth and voices variables to the utils/speechSynthesis.ts * utils/speechSynthesis.ts - exports the synth variable and synthesizeSpeech function - factors out some local functions for use in the synthesizeSpeech function
Open
|
Thanks @evgenyfadeev ! I added a couple of commits to remove redundant JSDocs that now use TypeScript types and fix a typo in a variable name, which I spotted because VS Code's Code Spell Checker extension by Street Side Software pointed it out. It's now deployed! |
|
Nice, thanks @didoesdigital I'll get this extension too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #168
it helped to do a few steps before getting to the useLesson hook