Removes redundant handleStopLesson method from App.js. #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* src/App.js:
- removes the handleStopLesson method
- removes it from the context
* src/pages/lessons/Lesson.tsx:
- removes handleStopLesson from props
- passes stopLesson to LessonSubheader instead of handleStopLesson
* src/pages/lessons/{Lesson,LessonSubheader,MainLessonView + stories}.tsx:
- replaces prop handleStopLesson with stopLesson
* src/pages/lessons/components/LessonSubheader.tsx:
- button onClick handler calls stopLesson after event.preventDefault()
|
Thanks @evgenyfadeev ! This looks great. I should have time to merge and publish this tomorrow (or maybe sooner). |
|
Thanks @evgenyfadeev ! I've merged and deployed the improvements. I really appreciate you tracking down that bit of code and cleaning it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change towards resolving #168