Convert AppRoutes to TS & Type Lessons' props better #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na2hiro
commented
May 10, 2024
Open
This was referenced May 24, 2024
|
Will be handled together with #171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During #168 I noticed there are some code that are untyped but could be typed relatively easily:
AppRoutesand Lessons' props where most of props were capturedwith {[name: string]: any}.I started with most conservative
unknown, which cannot be used without type guards, and repeatedly fixed where TS complains. I didn't eagerly type everything, so if some field requiresanytoday, such fields are keptunknown.