Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat rn picker-view #1760

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Feat rn picker-view #1760

wants to merge 28 commits into from

Conversation

wangshunnn
Copy link
Collaborator

@wangshunnn wangshunnn commented Dec 16, 2024 •
edited
Loading

No description provided.

@wangshunnn wangshunnn requested a review from hiyuki December 16, 2024 08:05
hiyuki
hiyuki reviewed Dec 24, 2024
View reviewed changes
packages/webpack-plugin/lib/runtime/components/react/mpx-picker-view-column-item.tsx
itemWidth,
textStyleFromParent,
textStyle,
hasVarDec,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不用传递下来啊

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

理论上这玩意不需要接收样式吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyuki hiyuki hiyuki left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangshunnn @hiyuki