Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Rdf ontology graph #163

Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open

Rdf ontology graph #163

wants to merge 70 commits into from

Conversation

himadri-kumari
Copy link
Collaborator

  1. Create and display RDF ontology graph as per new changes mentioned

  2. create and force directed graph in D3 version 4 for new RDF ontology data.

  3. Add filters tab which includes below functionalities
    i). Display in deustch
    ii). Include class heirarchy
    iii). Include all properties
    iv). Bounded graph
    v). Disable zoom
    vi). Reset graph.

  4. Add a card on the right side of graph for below functionalies
    i). Show node information on click.
    ii). Graph customization according to users.

  5. In graph on double click on any node expand or collapse it's children accordingly.

  6. In graph removing the edge label and replacing the literal node label to edge label.

7: In graph on-hover of any node or edge label display more info about it.

himadri-kumari and others added 21 commits June 22, 2019 17:10
2. implement on hover
3. diffterent colors for diferent types of nodes, edges label.
4. implement filter tab.
5. implement duestch conversion.
6. implement add class hierarch and all properties into filter tab.
implemented diable Zoom functionality and included it into filter tab.
2. implement right side card into rdf ontology graph component.
… label in literals nodes.

- for subclass edges change the marker color to gray.
- display the marker in correct position in graph.
- started implementing the double click function to display the node ifnormation in right side card.
Minor spell checks and docker
@codecov-io
Copy link

codecov-io commented Jul 1, 2019

Codecov Report

Merging #163 into master will increase coverage by 5.75%.
The diff coverage is 53.3%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #163      +/-   ##
============================================
+ Coverage     39.34%   45.09%   +5.75%     
- Complexity      152      202      +50     
============================================
  Files            51       54       +3     
  Lines          1337     1630     +293     
  Branches        144      204      +60     
============================================
+ Hits            526      735     +209     
- Misses          772      823      +51     
- Partials         39       72      +33
Impacted Files Coverage Δ Complexity Δ
.../main/java/upb/ida/rest/MessageRestController.java 52.94% <ø> (+16.94%) 2 <0> (ø) ⬇️
.../main/java/upb/ida/venndiagram/VennDataFilter.java 0% <0%> (ø) 0 <0> (?)
.../main/java/upb/ida/provider/GeoDiagramHandler.java 3.33% <0%> (-0.12%) 1 <0> (ø)
...main/java/upb/ida/provider/VennDiagramHandler.java 6.66% <0%> (-1.03%) 1 <0> (ø)
...java/upb/ida/provider/OntologyExplorerHandler.java 5.55% <0%> (-4.45%) 1 <0> (ø)
...c/main/java/upb/ida/provider/DataDumpProvider.java 100% <100%> (ø) 11 <8> (+6) ⬆️
...-ws/src/main/java/upb/ida/constant/IDALiteral.java 100% <100%> (ø) 1 <1> (?)
...-ws/src/main/java/upb/ida/provider/FdgHandler.java 60% <100%> (-2.5%) 2 <0> (ø)
...s/src/main/java/upb/ida/config/DataDumpConfig.java 100% <100%> (ø) 2 <2> (?)
ida-ws/src/main/java/upb/ida/fdg/FdgUtil.java 93.33% <100%> (ø) 8 <1> (?)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2afa9...6dc2c54. Read the comment docs.

@Cortys
Copy link
Collaborator

Cortys commented Jul 2, 2019

Great work! Please try fixing the Codacy issues so we can merge this. They are all eslint issues so please either make the sugggested code changes or add an eslintrc config (e.g. to declare globals, d3 in your case).

Edit: Apparently already resolved.

@himadri-kumari himadri-kumari requested a review from Cortys July 2, 2019 10:10
import java.util.*;
import java.io.*;
import upb.ida.util.FileUtil;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments missing


@Autowired
private FileUtil fileUtil;
public String fetchSysFilePath(String path) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method level comments missing

import upb.ida.ontologyExplorer.OntologyExplorer;

import java.util.Map;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments?

@@ -0,0 +1,670 @@
@prefix : <https://www.upb.de/historisches-institut/neueste-geschichte/ssdal/ontology/> .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file supposed to be pushed at all?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants