Skip to content

ISSUE: 42 and 30, implement headers to catalog v1 and get MimeType #147

ISSUE: 42 and 30, implement headers to catalog v1 and get MimeType

ISSUE: 42 and 30, implement headers to catalog v1 and get MimeType #147

Triggered via pull request October 30, 2023 08:08
Status Failure
Total duration 55s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors
lint: src/frontend/http.rs#L64
error: returning the result of a `let` binding from a block --> src/frontend/http.rs:72:25 | 64 | / let calculated_mime_type = match kind { 65 | | Some(mime_type) => { 66 | | *mime_hasher_guard = mime_type.mime_type().to_string(); 67 | | mime_type.mime_type().to_string() 68 | | } 69 | | None => "application/octet-stream".to_string(), 70 | | }; | |__________________________- unnecessary `let` binding 71 | 72 | calculated_mime_type | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `-D clippy::let-and-return` implied by `-D warnings` help: return the expression directly | 64 ~ 65 | 66 ~ match kind { 67 + Some(mime_type) => { 68 + *mime_hasher_guard = mime_type.mime_type().to_string(); 69 + mime_type.mime_type().to_string() 70 + } 71 + None => "application/octet-stream".to_string(), 72 + } |
lint: src/frontend/http.rs#L72
error: returning the result of a `let` binding from a block --> src/frontend/http.rs:72:25 | 64 | / let calculated_mime_type = match kind { 65 | | Some(mime_type) => { 66 | | *mime_hasher_guard = mime_type.mime_type().to_string(); 67 | | mime_type.mime_type().to_string() 68 | | } 69 | | None => "application/octet-stream".to_string(), 70 | | }; | |__________________________- unnecessary `let` binding 71 | 72 | calculated_mime_type | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `-D clippy::let-and-return` implied by `-D warnings` help: return the expression directly | 64 ~ 65 | 66 ~ match kind { 67 + Some(mime_type) => { 68 + *mime_hasher_guard = mime_type.mime_type().to_string(); 69 + mime_type.mime_type().to_string() 70 + } 71 + None => "application/octet-stream".to_string(), 72 + } |
lint
Process completed with exit code 1.