-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS Tiger platform and instructions #7578
Conversation
37782c1
to
63c5e23
Compare
When testing with SDL 1.2.15 from Tigerbrew I noticed that it's just dumping the saves and settings in the home folder so we need a Tinger/macOS addition to our implementation of SDL_GetPrefPath() in sdl2_to_1_2_backports.cpp |
1eeec52
to
d1100d0
Compare
Nice that you figured out the issue with the icon :) |
d1100d0
to
ac14530
Compare
c70b9ed
to
f6d70bc
Compare
a3e1b4b
to
faf70b0
Compare
dd6d51d
to
f7db7d6
Compare
Finder on OSX Tiger can only handle `icns` files with up to 128x128 icons. Adds a file with 128x128, 48x48, 32x32, and 16x16 icons.
f7db7d6
to
855ee79
Compare
@glebm Have you taken a look at SDL2? As of now, it probably won’t work for games, since joystick module needs to be fixed, but video works via x11. |
Pushing events from a background thread on Tiger + SDL1 does not appear to do anything at all. I don't know if the issue is limited to Tiger, so apply the workaround on all macOS when using SDL1.
855ee79
to
07d2432
Compare
@barracuda156 X11 server doesn't build from the current MacPorts due to https://trac.macports.org/ticket/62654 With this PR, DevilutionX should be buildable from upstream MacPorts! |
@glebm I see. I have probably built it only on 10.5 and 10.6 on PowerPC. |
DMG uploaded (see PR description)! |
@barracuda156 joystick support isn't required, it does throw an error because it fails to init it, but if you ignore that it works fien. From what I read the joystick issue originated in a bug in GCC as should be solved now that we have upgraded to GCC14 so the patch that disables it can probably be removed, but we can't currently test it because of the mentioned issues around building x11. |
|
||
To run tools from the `tools/` directory (only needed for development), you also need Python: | ||
|
||
~~~ bash | ||
sudo port install python312 | ||
sudo port select --set python python312 | ||
sudo port select --set python3 python312 | ||
~~~ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While not an issue I have a hard time seeing who would do so :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oddly having a target where the threaded loading isn't working properly makes me feel the solution is more robust 👍
This required a few workarounds, the trickiest one in the last commit of this PR.
We can also backport this to the 1.5 branch for the 1.5.4 release.
I haven't tested netplay between big-endian and little-endian machines but I'm guessing it is still broken.
devilutionx_tiger_ppc.dmg.zip
/cc @kencu @barracuda156 @mascguy