Extract hardcoded starting skill/spell/items and combat bonuses #6530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DakkJaniels
reviewed
Sep 1, 2023
ephphatha
force-pushed
the
data/playerdata
branch
2 times, most recently
from
ebdee20 to
e960cc4
Compare
ephphatha
force-pushed
the
data/playerdata
branch
from
e960cc4 to
84e1e67
Compare
ephphatha
force-pushed
the
data/playerdata
branch
2 times, most recently
from
c335a0c to
b1d3fbb
Compare
glebm
reviewed
Sep 17, 2023
ephphatha
force-pushed
the
data/playerdata
branch
from
b1d3fbb to
834f253
Compare
ephphatha
force-pushed
the
data/playerdata
branch
2 times, most recently
from
64de241 to
3d4e863
Compare
|
Rebased on #6608 the diff will shrink significantly when that is merged. I'm not looking forward to trying to load items from the per class files, but that's a problem for the future 😅 |
ephphatha
force-pushed
the
data/playerdata
branch
from
3d4e863 to
c8c9fb6
Compare
It's closely related to the values in that table so seems a better fit than PlayerData
This lets us remove the PlayersData global, and we can use a helper in the player class for convenience.
Bringing blockBonus along for the ride as it seems to fit (and renaming to align with the current convention)
ephphatha
force-pushed
the
data/playerdata
branch
from
c8c9fb6 to
d3a561a
Compare
ephphatha
changed the title
glebm
approved these changes
Sep 17, 2023
|
Super exciting with all the progress on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The low-hanging fruit of the areas kphoenix identified in #211. Based the split and naming convention off what was mentioned in discord (but written from memory so probably nowhere near the original).
Eventually aiming to load these values from CharacterAttributes.tsv, CharacterLoadouts.tsv, CharacterCombatStats.tsv (or something along those lines). D2 uses CharStats.txt for all of these combined which ends up being a massive 80 column wide file...