Fix: Compatibility with Qt5 + CPack configuration in CMakeLists + bump versions/cleanup files #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetektoza
force-pushed
the
fix_compatibility_with_qt5_control_file
branch
from
1ac0cd8 to
9c3764e
Compare
tetektoza
force-pushed
the
fix_compatibility_with_qt5_control_file
branch
2 times, most recently
from
a971c38 to
6579344
Compare
tetektoza
changed the title
tetektoza
force-pushed
the
fix_compatibility_with_qt5_control_file
branch
2 times, most recently
from
2b5ad6f to
5b717df
Compare
AJenbo
reviewed
Oct 19, 2023
tetektoza
force-pushed
the
fix_compatibility_with_qt5_control_file
branch
from
5b717df to
e782006
Compare
AJenbo
reviewed
Oct 19, 2023
| @@ -1,5 +1,5 @@ | |||
| [Desktop Entry] | |||
| Version=0.5.0 | |||
| Version=1.0.0 | |||
There was a problem hiding this comment.
I don't think this is actually has any benefits and with out it we will have one less things we have to remember to update on release.
Suggested change
| Version=1.0.0 |
There was a problem hiding this comment.
Done. I've added a couple of fields for the package, like section in which package lies, homepage of the package repository, description.
There was a problem hiding this comment.
I think you just reverted it rather then remove the line, i did so here: 1090703
There was a problem hiding this comment.
Ah right, my bad, didn't see it's line removal on commit change rather than character change.
tetektoza
force-pushed
the
fix_compatibility_with_qt5_control_file
branch
from
e782006 to
7a7905f
Compare
This patch adds CPack configuration to CMakeLists so CONTROL file for .deb packages can be deleted, and we can setup everything through cmake.
tetektoza
force-pushed
the
fix_compatibility_with_qt5_control_file
branch
from
7a7905f to
b5f2480
Compare
This patch removes CONTROL file from DEBIAN directory, as well as build-deb.sh script, since we started using CPack for packaging on debian.
tetektoza
force-pushed
the
fix_compatibility_with_qt5_control_file
branch
from
b5f2480 to
f9eed72
Compare
AJenbo
approved these changes
Oct 19, 2023
pionere
pushed a commit
to pionere/d1-graphics-tool
that referenced
this pull request
Oct 20, 2023
…p versions/cleanup files (diasurgical#117)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds CPack configuration to CMakeLists so CONTROL file for .deb packages can be deleted, it also removes the file + removes build-deb.sh since CPack will handle packaging now.