-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New games #114
Conversation
@@ -241,10 +242,15 @@ def _sanity_check(self): | |||
check_val_in_list("characters[{}]".format(idx), self.characters[idx], char_list) | |||
check_num_in_range("outfits", self.outfits, self.games_dict[self.game_id]["outfits"]) | |||
check_val_in_list("super_art", self.super_art, [None, 1, 2, 3]) | |||
check_val_in_list("fighting_style", self.fighting_style, [None, 1, 2, 3]) | |||
if self.game_id == "kof98umh": | |||
check_val_in_list("fighting_style", self.fighting_style, [None, 1, 2, 3]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw I recently learned about https://docs.pydantic.dev which would could help improving these validations. Just something to check out whenever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw I recently learned about https://docs.pydantic.dev which would could help improving these validations. Just something to check out whenever
Thanks a lot for the suggestion, will add this as a task!
But see test failures |
Yes to be re-evaluate after the release of the new engine |
No description provided.