sb3: Download model and config from huggingface #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discordianfish
force-pushed
the
sb3-use-hf
branch
from
c7f2245 to
74297ab
Compare
discordianfish
force-pushed
the
sb3-use-hf
branch
from
74297ab to
d27f48a
Compare
discordianfish
force-pushed
the
sb3-use-hf
branch
from
ac04c2d to
3a3c1db
Compare
|
@discordianfish Was taking a look at this. It has been a while so maybe I do not remember every passage, but why are we deleting in this PR the model cfg and zip files (weights)? I imagine the idea is to include them in the HF repo, but can't we leave them also here if we want to use github? |
|
This is more a proof-of-concept. We probably should have a self-contained, big sb3 image and a small one which downloads weights and config from hf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.