Merge pull request #46 from a-khushal/feature/pan-Using-Space-key

PR 41 broke the functionality, here's a fix to it
dhruvpatidar359 · May 15, 2024 · 1b823b2 · 1b823b2
2 parents d4356b3 + 5fdba6f
commit 1b823b2
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/components/Canvas.jsx b/components/Canvas.jsx
@@ -113,6 +113,7 @@ const Canvas = () => {
 
 
   useEffect(()=>{
+    const canvas = document.getElementById("canvas")
     const handleKeyDown = (event) => {
       setKeys(keys => new Set(keys).add(event.key));
     }
@@ -126,11 +127,11 @@ const Canvas = () => {
     };
 
     // console.log(keys)
-    window.addEventListener("keydown", handleKeyDown);
-    window.addEventListener("keyup", handleKeyUp);
+    canvas.addEventListener("keydown", handleKeyDown);
+    canvas.addEventListener("keyup", handleKeyUp);
     return () => {
-      window.removeEventListener("keydown", handleKeyDown);
-      window.removeEventListener("keyup", handleKeyUp);
+      canvas.removeEventListener("keydown", handleKeyDown);
+      canvas.removeEventListener("keyup", handleKeyUp);
     };
   },[keys])