Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect pluralizations in randomWord( "nns" ) #487

Open
dhowe opened this issue Jan 4, 2018 · 5 comments
Open

Incorrect pluralizations in randomWord( "nns" ) #487

dhowe opened this issue Jan 4, 2018 · 5 comments

Comments

@dhowe
Copy link
Owner

dhowe commented Jan 4, 2018

Some of these are due to mass nouns being pluralized; some are just incorrect pluralizations; some have no pluralizations; and some may be mistakes in the dict (I've fixed a number of these already):

feedbacks
clouts
slowness (still singular)
shortness (still singular)
steepness (still singular)
roach (still singular)
sadisms
refrigerations
polices
braveries
wakes
distastes
upstairses
rooves (should be roofs)
toothpastes
plutoniums

You can see the full list with the following Java code:

JSONLexicon lex = JSONLexicon.getInstance();
System.out.println(lex.getWordsWithPos("nns"));
  
@cqx931
Copy link
Collaborator

cqx931 commented Jan 5, 2018

Step1:

  • that are both 'nn' and 'vbg' at the same time(brewing, budgeting...)
  • end with 'ness' (slowness, loneliness...)
  • end with 'ism' (colonialism...)

@dhowe
Copy link
Owner Author

dhowe commented Jan 6, 2018

Have we discussed removing 'vbg' from the dict?

@dhowe dhowe modified the milestones: Version 1.3, Version 1.4 Jun 16, 2018
@dhowe
Copy link
Owner Author

dhowe commented Jun 16, 2018

status @cqx931 ?

@cqx931
Copy link
Collaborator

cqx931 commented Jun 18, 2018

We have discussed removeing 'vb*' in this ticket before: https://github.com/dhowe/RiTa/issues/357
Question:

  1. Should getWordsWithPos("nns") returns words end with 'ness'/'ism' at all?
  2. I was thinking about ignoring words that are both 'nn' and 'vbg' if the request is getWordsWithPos("nns"), what's your thoughts on 'vbg' for this issue?

@dhowe
Copy link
Owner Author

dhowe commented Jun 19, 2018

  1. Should getWordsWithPos("nns") returns words end with 'ness'/'ism' at all?

No. These are not considered plurals in this case

  1. I was thinking about ignoring words that are both 'nn' and 'vbg' if the request is getWordsWithPos("nns"), what's your thoughts on 'vbg' for this issue?

That makes sense to me, please proceed

@dhowe dhowe changed the title Incorrect pluralizations in randomWord( "nns" ); Incorrect pluralizations in randomWord( "nns" ) Nov 24, 2018
@dhowe dhowe added the bug label Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants