-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QUESTION: Remove regular VBG/VBD/VBN/VBZs from dictionary #536
Comments
A brief summary of the past discussion about this: The process of removing vb* from the dictionary seemed to be on hold from the removal of 'nns'. Since this is done by now, there should be no other reasons not to do this. TODO:
|
@dhowe any follow up comment? |
@cqx931 definitely want to do this for the 2.0 release -- have you done any work on it thus far? |
No, I can't recall any work already done for this. I can pick it up again. |
As you have time, not super critical, as release is still a couple of weeks off here: https://github.com/dhowe/rita-script/blob/master/src/rita_dict.js When we do this I want to explore adding sentiment markers to the dict (one int per word) as shown here: https://github.com/words/afinn-165/blob/master/index.json |
Please check: 2196 VBG only words were removed. The following words are not removed yet, because they are either also considered as adjective or noun.
|
Good start
Yes, please add it to the scripts dir
Why do you suggest this?
So many of these should be removed as well, but I will go through them manually. The harder part of this ticket is making other functions work correctly without these parts of speech. These include:
I will start adding tests for these cases |
On 'rb' tags: https://github.com/dhowe/RiTa/pull/586 |
That makes sense |
Moving this ticket to: https://github.com/dhowe/RiTaJSv2/issues |
When a word has a single POS that is 'vbg' and it is regular, and the verb also exists in the dictionary, it can be removed.
@cqx931 did we discuss this already? is there any reason not to do this?
We just need to do the conjugation for randomWord()
Some examples:
The text was updated successfully, but these errors were encountered: