This repository has been archived by the owner on Nov 27, 2021. It is now read-only.
Minor Fixes #7
Open
Minor Fixes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t_whitelist is an array, so when the length is 1, the zero-th element must be referenced. Otherwise, ruby will expand the array as a string, which will not result in a syntax which nrpe can understand.
This fixes the following error message in Puppet 3.1: Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Failed to parse template puppet-icinga/common/etc/icinga/htpasswd.users.erb: Filepath: /opt/puppet/lib/ruby/site_ruby/1.9.1/puppet/parser/functions.rb Line: 149 Detail: custom functions must be called with a single array that contains the arguments. For example, function_example([1]) instead of function_example(1) at /etc/puppetlabs/puppet/environments/production/modules/puppet-icinga/manifests/master.pp:47 on node your_node_name_here Warning: Not using cache on failed catalog Error: Could not retrieve catalog; skipping run
This fixes this error in Puppet 3.1: Error: Failed to apply catalog: Parameter unless failed on Exec[external-commands]: 'dpkg-statoverride --list nagios nagios 751 /var/lib/icinga && dpkg-statoverride --list nagios www-data 2710 /var/lib/icinga/rw' is not qualified and no path was specified. Please qualify the command or specify a path. at /etc/puppetlabs/puppet/environments/production/modules Wrapped exception: 'dpkg-statoverride --list nagios nagios 751 /var/lib/icinga && dpkg-statoverride --list nagios www-data 2710 /var/lib/icinga/rw' is not qualified and no path was specified. Please qualify the command or specify a path. And this error too: Error: Failed to apply catalog: Validation of Exec[fix-permissions] failed: 'chmod -R go+r /etc/icinga/objects' is not qualified and no path was specified. Please qualify the command or specify a path. at /etc/puppetlabs/puppet/environments/production/modules/puppet-icinga/manifests/master.pp:18 Wrapped exception: 'chmod -R go+r /etc/icinga/objects' is not qualified and no path was specified. Please qualify the command or specify a path.
|
Whoops!, looks like I munged my repo with a rebase gone wrong... Two of these commits are yours. Apply with care. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few fixes I had to make to get this module to work with Puppet 3.1.
I hope you'll apply these changes to help the next guy.