fix: remove members references from user group form [DHIS2-16766] #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an update for #1328 to backport some changes for user group form (and to fix a bug where one could not edit groups assigned to user groups).
However, the code I backported had references to members (which are not editable on v38 because bulk member edit is not a feature there). As a result, an error occurred when saving a new user group (DHIS2-16766)
This PR removes the references to members on user group add and edit (the code for edit didn't do anything because there is no members field in the form).
I've tested to confirm that I can create a new user group and edit the user group management for existing user groups