chore: remove numTestsKeptInMemory from cypress config because default behaviour is better #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t behaviour is better
|
🚀 Deployed on https://pr-602.line-listing.netlify.dhis2.org |
BRaimbault
approved these changes
Oct 17, 2024
|
🎉 This PR is included in version 101.1.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No JIRA issue available,
Having
numTestsKeptInMemoryset to a low number can make local debugging usingcy:opendifficult. Normally you can hover over steps to see the state of the DOM in each one. However, when the number of tests in the current test file exceed the value ofnumTestsKeptInMemory, you well start seeing message sayingThe snapshot is missing. Displaying current state of the DOMfor the first tests in the file.After inspecting the Cypress docs, it turns out that the default behaviour is actually what we want:
This way we should not encounter out-of-memory errors on CI (which uses
cypress run), and we should be able to visually debug tests locally usingcypress open.Also see this Slack thread