Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add custom errors for analytics requests (DHIS2-15657) #445

Merged
merged 6 commits into from
Dec 8, 2023

Conversation

martinkrulltott
Copy link
Contributor

@martinkrulltott martinkrulltott commented Oct 13, 2023

Implements DHIS2-15657


Key features

  1. Adds custom error handling for E7144 and E7145

Screenshots

image

@martinkrulltott martinkrulltott requested a review from a team as a code owner October 13, 2023 13:19
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Oct 13, 2023

🚀 Deployed on https://pr-445--dhis2-line-listing.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify October 13, 2023 13:22 Inactive
@cypress
Copy link

cypress bot commented Oct 13, 2023

6 failed tests on run #2094 ↗︎

6 499 0 0 Flakiness 0

Details:

Merge 706d356 into 0110907...
Project: line-listing-app Commit: 4f92513441 ℹ️
Status: Failed Duration: 12:47 💡
Started: Dec 1, 2023 1:22 PM Ended: Dec 1, 2023 1:34 PM
Failed  conditions/optionSetCondition.cy.js • 1 failed test • e2e-chrome-parallel-2.38

View Output Video

Test Artifacts
Option set condition > Options with same code but from different option sets display correctly Test Replay Screenshots Video
Failed  table.cy.js • 1 failed test • e2e-chrome-parallel-2.38

View Output Video

Test Artifacts
table > option set option labels show correctly Test Replay Screenshots Video
Failed  conditions/optionSetCondition.cy.js • 1 failed test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Option set condition > Options with same code but from different option sets display correctly Test Replay Screenshots Video
Failed  table.cy.js • 1 failed test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
table > option set option labels show correctly (>=2.39) Test Replay Screenshots Video
Failed  conditions/optionSetCondition.cy.js • 1 failed test • e2e-chrome-parallel-2.39

View Output Video

Test Artifacts
Option set condition > Options with same code but from different option sets display correctly Test Replay Screenshots Video

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #445 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify October 26, 2023 12:42 Inactive
@janhenrikoverland
Copy link
Collaborator

@martinkrulltott Conflict

@dhis2-bot dhis2-bot temporarily deployed to netlify November 9, 2023 14:39 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 23, 2023 12:20 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 1, 2023 13:18 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 8, 2023 13:53 Inactive
@janhenrikoverland janhenrikoverland enabled auto-merge (squash) December 8, 2023 13:53
@janhenrikoverland janhenrikoverland merged commit cecd9a5 into master Dec 8, 2023
26 checks passed
@janhenrikoverland janhenrikoverland deleted the feat/DHIS2-15657-analytics-errors branch December 8, 2023 14:06
dhis2-bot added a commit that referenced this pull request Dec 8, 2023
## [100.11.3](v100.11.2...v100.11.3) (2023-12-08)

### Bug Fixes

* add custom errors for analytics requests ([#445](#445)) ([cecd9a5](cecd9a5))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

edoardo pushed a commit that referenced this pull request Jan 4, 2024
edoardo pushed a commit that referenced this pull request Jan 4, 2024
## [100.11.3](v100.11.2...v100.11.3) (2023-12-08)

### Bug Fixes

* add custom errors for analytics requests ([#445](#445)) ([cecd9a5](cecd9a5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants