Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: take legend-key into account when computing pagination max-width #444

Closed

Conversation

HendrikThePendric
Copy link
Contributor

@HendrikThePendric HendrikThePendric commented Oct 12, 2023

Fixes (another) regression in DHIS2-15465


Key features

  1. Pagination is now also correct when a legend key is showing

Screenshots

Before
Screenshot 2023-10-12 at 15 29 06

After
Screenshot 2023-10-12 at 15 28 39

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-444--dhis2-line-listing.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify October 12, 2023 13:37 Inactive
@cypress
Copy link

cypress bot commented Oct 12, 2023

Passing run #1814 ↗︎

0 488 2 0 Flakiness 0

Details:

Merge ec50702 into abb57d0...
Project: line-listing-app Commit: c1012839d3 ℹ️
Status: Passed Duration: 45:08 💡
Started: Oct 12, 2023 2:38 PM Ended: Oct 12, 2023 3:23 PM

Review all test suite changes for PR #444 ↗︎

@HendrikThePendric
Copy link
Contributor Author

Closing in favour of #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants