fix: visualization deleted when saving it after copy (DHIS2-15722) #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
requested review from
janhenrikoverland
and removed request for
janhenrikoverland
edoardo
force-pushed
the
fix/ao-deleted-after-copy-DHIS2-15722
branch
from
30a5dd2 to
ba571ee
Compare
|
🚀 Deployed on https://pr-433--dhis2-line-listing.netlify.app |
Passing run #2077 ↗︎
Details:
Review all test suite changes for PR #433 ↗︎ |
|||||||||||||||
Merged
2 tasks
Added a Cypress test in DV. |
edoardo
force-pushed
the
fix/ao-deleted-after-copy-DHIS2-15722
branch
2 times, most recently
from
ce27c86 to
52a5a76
Compare
edoardo
force-pushed
the
fix/ao-deleted-after-copy-DHIS2-15722
branch
from
52a5a76 to
3f11932
Compare
edoardo
force-pushed
the
fix/ao-deleted-after-copy-DHIS2-15722
branch
from
3f11932 to
b39ce77
Compare
user is not used anyway and creates problems when saving a copied AO.
edoardo
force-pushed
the
fix/ao-deleted-after-copy-DHIS2-15722
branch
from
b39ce77 to
65d6605
Compare
janhenrikoverland
changed the title
janhenrikoverland
approved these changes
Nov 30, 2023
dhis2-bot
added a commit
that referenced
this pull request
Nov 30, 2023
## [100.11.1](v100.11.0...v100.11.1) (2023-11-30) ### Bug Fixes * visualization deleted when saving it after copy (DHIS2-15722) ([#433](#433)) ([f505c50](f505c50))
|
🎉 This PR is included in version 100.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-15722
Requires dhis2/analytics#1573
Key features
Description
Refer to the ticket for the explanation on why it happened.
The PR fixes the issue by cleaning up the payload passed to the POST request for copying an existing visualization.