Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly center the table spinner (DHIS2-13947, DHIS2-13946) #432

Closed
wants to merge 1 commit into from
Closed

fix: correctly center the table spinner (DHIS2-13947, DHIS2-13946) #432

wants to merge 1 commit into from

Conversation

HendrikThePendric
Copy link
Contributor

@HendrikThePendric HendrikThePendric commented Sep 7, 2023 •
edited
Loading

Implements DHIS2-13947 & DHIS2-13946

Key features

  1. Fixes spinner positioning

Description

  • As discussed, the horizontal alignment has remained unchanged.
  • A fix in @dhis2/ui would be very involved, so a fix in the app was made
  • I have reduced the spinner size by half, so it now fits into a single row
  • I have tested vertical alignment in the main canvas, in the modal, for scrollable tables and tables with as few as one single row. In all these cases the alignment looked perfect.

Note

  • To test I recommend toggling the network traffic to slow 3g

Screenshots

Screenshot 2023-09-11 at 15 05 30 Screenshot 2023-09-11 at 15 04 00 Screenshot 2023-09-11 at 15 02 23 Screenshot 2023-09-11 at 14 59 25

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Sep 7, 2023 •
edited
Loading

🚀 Deployed on https://pr-432--dhis2-line-listing.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify September 7, 2023 16:01 Inactive
@cypress
Copy link

cypress bot commented Sep 7, 2023 •
edited
Loading

Passing run #1714 ↗︎

0 488 2 0 Flakiness 0

Details:

Merge c9f6e5c into 181c14f...
Project: line-listing-app Commit: 96303eac72 ℹ️
Status: Passed Duration: 25:57 💡
Started: Sep 25, 2023 3:44 PM Ended: Sep 25, 2023 4:10 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@martinkrulltott martinkrulltott self-requested a review September 8, 2023 06:51
@martinkrulltott martinkrulltott self-assigned this Sep 8, 2023
@martinkrulltott martinkrulltott changed the title fix: correctly center the table spinner fix: correctly center the table spinner (DHIS2-13947, DHIS2-13946) Sep 8, 2023
@dhis2-bot dhis2-bot temporarily deployed to netlify September 25, 2023 15:41 Inactive
@HendrikThePendric HendrikThePendric mentioned this pull request Oct 16, 2023
Merged
@HendrikThePendric
Copy link
Contributor Author

Closing in favour of #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkrulltott martinkrulltott martinkrulltott approved these changes

Assignees

@HendrikThePendric HendrikThePendric

Labels
Analytics Team Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HendrikThePendric @dhis2-bot @martinkrulltott