Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make "greater than or equal to" render on a single line for conditions (DHIS2-14030) #430

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

martinkrulltott
Copy link
Contributor

@martinkrulltott martinkrulltott commented Sep 5, 2023

Implements DHIS2-14030


Key features

  1. Increase width of the operator select

Screenshots

image

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Sep 5, 2023

🚀 Deployed on https://pr-430--dhis2-line-listing.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify September 5, 2023 08:41 Inactive
@cypress
Copy link

cypress bot commented Sep 5, 2023

Passing run #1767 ↗︎

0 488 2 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 4641a6b into 93ae4c4...
Project: line-listing-app Commit: b588c98f7b ℹ️
Status: Passed Duration: 52:33 💡
Started: Oct 3, 2023 9:59 AM Ended: Oct 3, 2023 10:51 AM

Review all test suite changes for PR #430 ↗︎

@martinkrulltott martinkrulltott requested review from cooper-joe and removed request for edoardo September 7, 2023 08:33
@martinkrulltott martinkrulltott assigned cooper-joe and unassigned edoardo Sep 7, 2023
@dhis2-bot dhis2-bot temporarily deployed to netlify September 7, 2023 10:51 Inactive
@martinkrulltott
Copy link
Contributor Author

dev+reviewer tested by me and Edoardo

@dhis2-bot dhis2-bot temporarily deployed to netlify September 28, 2023 07:51 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 2, 2023 08:30 Inactive
Copy link
Collaborator

@janhenrikoverland janhenrikoverland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of @cooper-joe

@dhis2-bot dhis2-bot temporarily deployed to netlify October 3, 2023 08:12 Inactive
@martinkrulltott martinkrulltott requested a review from a team as a code owner October 3, 2023 09:51
@dhis2-bot dhis2-bot temporarily deployed to netlify October 3, 2023 09:54 Inactive
@martinkrulltott martinkrulltott merged commit 4886533 into master Oct 3, 2023
17 checks passed
@martinkrulltott martinkrulltott deleted the fix/DHIS2-14030-dropdown-width branch October 3, 2023 12:12
dhis2-bot added a commit that referenced this pull request Oct 3, 2023
## [100.9.4](v100.9.3...v100.9.4) (2023-10-03)

### Bug Fixes

* make "greater than or equal to" render on a single line for conditions (DHIS2-14030) ([#430](#430)) ([4886533](4886533))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants