Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lack of access show the generic "something went wrong" error (DHIS2-15737) #429

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

martinkrulltott
Copy link
Contributor

@martinkrulltott martinkrulltott commented Sep 5, 2023

Implements DHIS2-15737


Key features

  1. Adds custom errors for certain error codes related to access

Screenshots

image

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Sep 5, 2023

🚀 Deployed on https://pr-429--dhis2-line-listing.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify September 5, 2023 07:32 Inactive
@cypress
Copy link

cypress bot commented Sep 5, 2023

Passing run #1751 ↗︎

0 488 2 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 849486c into 7f0fee4...
Project: line-listing-app Commit: aae9263fa7 ℹ️
Status: Passed Duration: 52:57 💡
Started: Oct 2, 2023 7:07 AM Ended: Oct 2, 2023 8:00 AM

Review all test suite changes for PR #429 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify September 12, 2023 13:14 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify September 28, 2023 07:53 Inactive
@martinkrulltott martinkrulltott merged commit 995ae74 into master Oct 2, 2023
17 checks passed
@martinkrulltott martinkrulltott deleted the fix/DHIS2-15737-access-errors branch October 2, 2023 08:27
dhis2-bot added a commit that referenced this pull request Oct 3, 2023
## [100.9.3](v100.9.2...v100.9.3) (2023-10-03)

### Bug Fixes

* **translations:** sync translations from transifex (master) ([3aa158d](3aa158d))
* ensure pagination max-width is correct in interpretations modal ([#434](#434)) ([2b733f1](2b733f1))
* lack of access show the generic "something went wrong" error (DHIS2-15737) ([#429](#429)) ([995ae74](995ae74))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants