feat: distinguish non-existent repetitions from empty values in line lists (DHIS2-15767) #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-427--dhis2-line-listing.netlify.app |
3 tasks
Passing run #2062 ↗︎
Details:
Review all test suite changes for PR #427 ↗︎ |
|||||||||||||||
martinkrulltott
added
the
Awaiting Core Release
janhenrikoverland
approved these changes
Oct 9, 2023
|
This requires a backend change (DHIS2-14420) which has been backported but currently hasn't been released yet. The Cypress tests are hence failing on 38, 39, 40. Once the patches are released this PR can be manually tested and merged. |
dhis2-bot
added a commit
that referenced
this pull request
Nov 30, 2023
# [100.11.0](v100.10.6...v100.11.0) (2023-11-30) ### Features * distinguish non-existent repetitions from empty values in line lists (DHIS2-15767) ([#427](#427)) ([675118d](675118d))
|
🎉 This PR is included in version 100.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-15767
Requires DHIS2-14420
Requires core patches: 38.5.0, 39.3.1, 40.2.0
Blocked by dhis2/ui#1401
Key features
Description
Extracts the necessary metadata from
rowContextto display diagonal lines in a cell which value is undefined (to differentiate it from a cell which is just empty). Currently the only time a cell's value is undefined is if repeated events are used and the repetition goes out of bounds (i.e. there are no events available). There's also a tooltip shown on hover.TODO
TooltipfromuiScreenshots