Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): platform fixes for login redirect [DHIS2-15320] #366

Merged
merged 8 commits into from
Oct 31, 2023

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented May 23, 2023

Implements DHIS2-15320,
and see parent issue DHIS2-15316

  • Custom app build tested on debug

Testing instructions:

Note that this can't be tested on Netlify, because redirects are handled differently there 😢

Before:

ll-app-login-modal-error.mov

After:

ll-app-redirect-success.mov

@dhis2-bot
Copy link
Contributor

dhis2-bot commented May 23, 2023

🚀 Deployed on https://pr-366--dhis2-line-listing.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify May 23, 2023 14:48 Inactive
@KaiVandivier KaiVandivier requested review from edoardo and a team May 23, 2023 14:57
@cypress
Copy link

cypress bot commented May 23, 2023

Passing run #1868 ↗︎

0 487 0 0 Flakiness 0

Details:

Merge 000931f into 22e3173...
Project: line-listing-app Commit: 021e7cd02b ℹ️
Status: Passed Duration: 24:24 💡
Started: Oct 31, 2023 8:38 AM Ended: Oct 31, 2023 9:02 AM

Review all test suite changes for PR #366 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify September 6, 2023 08:56 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify September 29, 2023 08:59 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 3, 2023 12:40 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 12, 2023 06:41 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 19, 2023 09:27 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 25, 2023 20:36 Inactive
@janhenrikoverland janhenrikoverland enabled auto-merge (squash) October 25, 2023 20:52
@dhis2-bot dhis2-bot temporarily deployed to netlify October 31, 2023 08:31 Inactive
@janhenrikoverland janhenrikoverland merged commit dde8a92 into master Oct 31, 2023
22 checks passed
@janhenrikoverland janhenrikoverland deleted the dhis2-15320-platform-deps-login branch October 31, 2023 09:10
dhis2-bot added a commit that referenced this pull request Oct 31, 2023
## [100.10.2](v100.10.1...v100.10.2) (2023-10-31)

### Bug Fixes

* **deps:** platform fixes for login redirect [DHIS2-15320] ([#366](#366)) ([dde8a92](dde8a92))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.10.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants