Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use UID in enrollment exporter [DHIS2-17790] #18898

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

enricocolasante
Copy link
Contributor

@enricocolasante enricocolasante commented Oct 23, 2024

Harmonize the usage of UID instead of plain String in tracker.

  • Use UID in EnrollmentService and propagate the change until the generic stores.
  • Use UID in EnrollmentOperationParams and propagate until the generic stores and until tracker stores when building the queries.

EnrollmentRequestParams are already using UIDs.
EnrollmentOperationParams are now using UIDs.
EnrollmentQueryParams is using hibernate object to build the query. The only field that is now using UIDs is enrollmentUids and they are passed to the store and the value is used to build the query.

Next steps*

  • Harmonize UID in TrackedEntity
  • Harmonize UID in Event
  • Harmonize UID in Relationship
  • Harmonize UID in OperationsParamsValidator
  • Harmonize UID in deduplication package
  • Harmonize UID in remaining tracker packages

@enricocolasante enricocolasante marked this pull request as ready for review October 23, 2024 10:01
@enricocolasante enricocolasante requested a review from a team as a code owner October 23, 2024 10:01
@enricocolasante enricocolasante enabled auto-merge (squash) October 23, 2024 13:12
Copy link

@enricocolasante enricocolasante merged commit b936071 into master Oct 23, 2024
13 checks passed
@enricocolasante enricocolasante deleted the DHIS2-17790-enrollment branch October 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants