chore: Validate completedAt for Event and Enrollment [DHIS2-18222]

[enricocolasante]

This PR fixes the logic around completion of enrollments and events.

Enrollments
A saved enrollment follows these rules:

• When an enrollment has status COMPLETED, fields completedAt and completedBy must be populated
• When an enrollment has status CANCELLED, fields completedAt must be populated and completedBy must be null
• When an enrollment has status ACTIVE, fields completedAt and completedBy must be null

Events
A saved event follows these rules:

• When an event has status COMPLETED, fields completedAt and completedBy must be populated
• When an event has status that is not COMPLETED, fields completedAt and completedBy must be null

Fields logic

completedBy is always calculated by the system, if required by the status, and it will be set to current user.
completedAt is set by the client or calculated by the system if not present, only when the status required it. The use case for it is Android sync where an event/enrollment is completed on day X and the sync happens on day Y, we still want completedAt to be X.

completedBy and completedAt are set only if the status is changing. Otherwise, the value for those fields present in the DB will not be updated.

If the status do not require completedAt field to be set but the client set it, a validation error is returned.

[teleivo]

completedAt

Completed events/enrollments can transition to other states again right? Does this logic you describe then apply in the same way if an event was previously completed?

[enricocolasante]

completedAt

Completed events/enrollments can transition to other states again right? Does this logic you describe then apply in the same way if an event was previously completed?

Yes, I updated the description to state that the completed fields are updated only if there is a transition.
So, if a completed event is updating one data element and it is not setting the completedAt field, the old completedAt previously calculated by the system will still be in the DB and it will not be updated.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud