Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Safely serialize JSON map [DHIS2-18253] [2.40] #18875

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

larshelge
Copy link
Member

@larshelge larshelge commented Oct 18, 2024

This PR makes the JsonAttributeValueBinaryType more reliable against bad data in the attributevalues JSONB column in metadata tables like organisationunit.

A null key in the JSONB column will lead to an exception from Jackson.

com.fasterxml.jackson.databind.JsonMappingException: Null key for a Map not allowed in JSON

@larshelge larshelge changed the title fix: Safely serialize JSON map fix: Safely serialize JSON map [DHIS2-18253] Oct 18, 2024
@larshelge larshelge changed the title fix: Safely serialize JSON map [DHIS2-18253] fix: Safely serialize JSON map [DHIS2-18253] [2.40] Oct 18, 2024
Copy link

@larshelge larshelge requested review from netroms and jbee October 18, 2024 13:13
Copy link
Contributor

@jbee jbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This is no longer an issue in 2.42 after my latest attribute cleanup

@larshelge larshelge merged commit 15457f5 into 2.40 Oct 22, 2024
13 checks passed
@larshelge larshelge deleted the DHIS2-18253 branch October 22, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants