ANDROAPP-6535-Bidirectional-relationships-are-created-in-the-oppsite-direction-when-created-from-TO #3928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmr
force-pushed
the
ANDROAPP-6535-Bidirectional-relationships-are-created-in-the-oppsite-direction-when-created-from-TO
branch
2 times, most recently
from
dabf4d7 to
f15a858
Compare
Balcan
reviewed
Dec 18, 2024
andresmr
force-pushed
the
ANDROAPP-6535-Bidirectional-relationships-are-created-in-the-oppsite-direction-when-created-from-TO
branch
from
f15a858 to
50e1cbf
Compare
xavimolloy
reviewed
Dec 18, 2024
| } | ||
| } | ||
| return RelationshipModel( | ||
| relationship, |
There was a problem hiding this comment.
This is a huge data model with a lot of parameters, do you think it would make sense to group some of the parameters to a separate model like RelationshipGeometry, RelationshipProfileDetails, etc...?
tracker/src/main/kotlin/org/dhis2/tracker/relationships/data/RelationshipsRepository.kt
Outdated
Show resolved
Hide resolved
| //Here checks if the TEI is the from or to of the relationship | ||
| when (teiUid) { | ||
| relationship.from()?.trackedEntityInstance()?.trackedEntityInstance() -> { | ||
| direction = RelationshipDirection.TO |
There was a problem hiding this comment.
Do you think it would make sense to extract these assignments into separate functions ?
andresmr
force-pushed
the
ANDROAPP-6535-Bidirectional-relationships-are-created-in-the-oppsite-direction-when-created-from-TO
branch
from
50e1cbf to
74124cc
Compare
xavimolloy
approved these changes
Dec 19, 2024
Balcan
force-pushed
the
ANDROAPP-6535-Bidirectional-relationships-are-created-in-the-oppsite-direction-when-created-from-TO
branch
from
74124cc to
a867f5b
Compare
…rogram and then the TEIType Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
…p type Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
xavimolloy
force-pushed
the
ANDROAPP-6535-Bidirectional-relationships-are-created-in-the-oppsite-direction-when-created-from-TO
branch
from
a867f5b to
b958111
Compare
|
Balcan
deleted the
ANDROAPP-6535-Bidirectional-relationships-are-created-in-the-oppsite-direction-when-created-from-TO
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix create bidirectional relationship creation
jira issue