-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [ANDROAPP-6660] Incorrect list of available periods #3923
Open
Balcan
wants to merge
16
commits into
develop
Choose a base branch
from
ANDROAPP-6660
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavimolloy
reviewed
Dec 11, 2024
form/src/main/java/org/dhis2/form/ui/provider/inputfield/PeriodSelectorProvider.kt
Show resolved
Hide resolved
ui-components/src/main/java/org/dhis2/ui/dialogs/bottomsheet/BottomSheetDialog.kt
Show resolved
Hide resolved
mmmateos
approved these changes
Dec 11, 2024
andresmr
requested changes
Dec 12, 2024
xavimolloy
approved these changes
Dec 13, 2024
andresmr
requested changes
Dec 13, 2024
commons/src/main/java/org/dhis2/commons/periods/domain/GetEventPeriods.kt
Outdated
Show resolved
Hide resolved
Balcan
force-pushed
the
ANDROAPP-6660
branch
from
December 13, 2024 14:20
8980ccf
to
2e28971
Compare
andresmr
approved these changes
Dec 19, 2024
Balcan
force-pushed
the
ANDROAPP-6660
branch
from
December 23, 2024 12:25
f38a714
to
3b98443
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and include the related jira issue if it exists.
[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-
Solution description
If this PR is a fix include a brief description on how the issue is solved.
Covered unit test cases
Describe the tests that you ran to verify your changes.
Where did you test this issue?
Which Android versions did you test this issue?
Checklist