-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [DHIS2-18310] enable non-Gregorian calendars in views & lists & forms #3900
base: master
Are you sure you want to change the base?
feat: [DHIS2-18310] enable non-Gregorian calendars in views & lists & forms #3900
Conversation
8983fd7
to
0294f8d
Compare
src/core_modules/capture-core/components/FiltersForTypes/Date/DateFilter.component.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/FiltersForTypes/Date/DateFilter.component.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/FiltersForTypes/Date/DateFilter.component.js
Outdated
Show resolved
Hide resolved
…non-gregorian-calendars-in-views-and-lists
Hi @alaa-yahia,
Screen.Recording.2024-12-12.at.16.51.40.movIn the video above I used the Ethiopian calendar. Can you have a look? Thank you! |
…ent date (#3905) feat: typing the date when editing enrollment and incident date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start, but some things we will have to work a bit more on.
In addition to the individual comments we should convert the "last updated" tooltips from ISO to local calendar (I saw this in both the stages and events Widget and the enrollment Widget). Had a very quick look at the stages and events Widget and for now I think you can use something like moment(fromServerDate(updatedAt)).toISOString()
and put the result into the clientToView converter of type DATETIME (we should probably also use the serverToClient converter, but this will be checked and resolved in separate ticket)
src/core_modules/capture-core/components/FiltersForTypes/Date/DateFilter.component.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/D2Form/field/configs/dateField/getDateFieldConfig.js
Outdated
Show resolved
Hide resolved
…non-gregorian-calendars-in-views-and-lists
Implements DHIS2-18310 & DHIS2-18311 & DHIS2-18309