fix: [DHIS2-16801] events scheduled for today's date not showing today #3856
Conversation
| return { status: statusTypes.SCHEDULE, options: undefined }; | ||
| } | ||
|
|
||
| if (daysUntilDueDate === 0) { | ||
| return { status: statusTypes.SCHEDULE, options: 'today' }; |
There was a problem hiding this comment.
Is this the string that get's displayed in the badge? If so, do you think it makes sense to add translations?
There was a problem hiding this comment.
@eirikhaugstulen No, it isn't the string that ended up being displayed, it gets passed to this function here and get translated.
There was a problem hiding this comment.
The string is passed as a dynamic value into the translation. As far as I understand from the i18next interpolation docs, a dynamic value is not translated. When I change the language to French, this is what is currently displayed:
By adding translations option: i18n.t('Today') as Eirik suggested, the text is translated correctly:
Could you please recheck @alaa-yahia? Let me know if you need any help or have doubts. Thank you!
PS: For these examples, I deliberately chose 'Today' in uppercase because the string already exists translated in the language files, but you can also use lowercase and Transfix will add the translations in a few weeks.
There was a problem hiding this comment.
Ah whoops! I noticed dueDateFromNow was being translated, so I figured the same would happen with today's date. Didn't realize moment.js has a localization.
alaa-yahia
force-pushed
the
DHIS2-16801-events-scheduled-for-today-date-should-show-today
branch
from
0db8ee0 to
c06023e
Compare
|
🚀 Deployed on https://deploy-preview-3856.capture.netlify.dhis2.org |
…scheduled-for-today-date-should-show-today
alaa-yahia
deleted the
DHIS2-16801-events-scheduled-for-today-date-should-show-today
branch
## [101.16.7](v101.16.6...v101.16.7) (2024-11-25) ### Bug Fixes * [DHIS2-16801] events scheduled for today's date not showing today ([#3856](#3856)) ([d63e124](d63e124))
|
🎉 This PR is included in version 101.16.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Implements DHIS2-16801