fix: do not call period generator with non-4-digit year (DHIS2-17707) #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
approved these changes
Jul 12, 2024
dhis2-bot
added a commit
that referenced
this pull request
Jul 12, 2024
## [26.7.8](v26.7.7...v26.7.8) (2024-07-12) ### Bug Fixes * do not call period generator with non-4-digit year (DHIS2-17707) ([#1690](#1690)) ([f2f516d](f2f516d))
|
🎉 This PR is included in version 26.7.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-17707
Key features
Description
multi-calendar-datesassumes the date strings have a 4 digit year, if not, a validation error is thrown.The fix ensures the period generator functions in
multi-calendar-datesare only called if the year is a 4-digit number.The error only shows a console.log in the app, but it's causing Cypress to fail due to the error overlay covering the app.
Screenshots
Before:
After:
The error is not thrown and the list of periods remain unchanged: