fix(pivot-table): use scoped styles instead of global styles #1681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-14028
Key features
Description
The styles were probably originally declared using
css.global
because they should in fact affect nested components, and this doesn't happen normally because each component has its own CSS scope. But by making the entire style block global, plus using a generic CSS selector liketable
, the risk of these styles affecting other parts of the page becomes very significant.What we need is "global" styles that impact sub-components but do not bleed out to sibling and parent components. In
@dhis2/ui
we have had to deal with this type of situation a lot and the most convenient pattern we established is the one I've applied here:css
and notcss.global
)PivotTableContainer
component which imports these styles.Test instructions
This fix can actually be verified without installing this analytics bundle into DV. You can just use the storybook to test things out.
Screenshots
Before
After