feat: add classname prop to hover-menu-dropdown #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
requested review from
jenniferarnesen
and removed request for
a team
jenniferarnesen
approved these changes
Jan 24, 2024
This was referenced Jan 24, 2024
HendrikThePendric
deleted the
feat/add-classname-prop-to-hover-menu-dropdown
branch
|
🎉 This PR is included in version 26.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: No issue number available
Relates to DHIS2-15367 (push-analytics)
Key features
HoverMenuItemcomponentDescription
Push analytics relies on clearly identifyable elements to be in the DOM to trigger a download. This PR will allow the consuming apps to provide a unique static classname on the download dropdown menu.
Note that the same is also needed for the the
HoverMenuListItemcomponent, but this already had aclassNameprop.