fix: use json+patch for PATCH requests #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jenniferarnesen
approved these changes
Nov 6, 2023
dhis2-bot
added a commit
that referenced
this pull request
Nov 7, 2023
## [26.1.6](v26.1.5...v26.1.6) (2023-11-07) ### Bug Fixes * use json+patch for PATCH requests ([#1593](#1593)) ([bdb0b9c](bdb0b9c))
|
🎉 This PR is included in version 26.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-16154
Relates to dhis2/line-listing-app#455
Key features
Description
In some cases we don't want to send the whole payload when updating some object via an api request.
Before we used an
updaterequest type withpartialset to true inapp-runtime.This type of PATCH request is deprecated.
The new way of doing this is by using a
json+patchrequest.app-runtimesupports this but some changes are needed in our apps wherever a partial update is used.Screenshots
Before, adding/editing a description in the rename dialog throws an error:
After, adding/editing the description in the rename dialog works, the payload is now formatted as json+patch:
