fix: handle both Set and array for currentUser.authorities when checking interpretations access [DHIS2-15964] #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
approved these changes
Oct 5, 2023
src/components/Interpretations/common/getInterpretationAccess.js
Outdated
Show resolved
Hide resolved
src/components/Interpretations/common/getInterpretationAccess.js
Outdated
Show resolved
Hide resolved
HendrikThePendric
requested changes
Oct 9, 2023
src/components/Interpretations/common/getInterpretationAccess.js
Outdated
Show resolved
Hide resolved
HendrikThePendric
requested changes
Oct 9, 2023
src/components/Interpretations/common/getInterpretationAccess.js
Outdated
Show resolved
Hide resolved
HendrikThePendric
approved these changes
Oct 12, 2023
HendrikThePendric
approved these changes
Oct 16, 2023
|
Changes by @HendrikThePendric LGTM. The function should throw an error if the needed arguments are not provided by the app. |
jenniferarnesen
changed the title
|
Superseded by the combo PR #1588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://dhis2.atlassian.net/browse/DHIS2-15964
In the olden days when we used d2.currentUser,
authoritieswas a Set.With the migration to the app-runtime, requesting currentUser or /me with the dataEngine, the
authoritieswill be an array.Choosing here to handle both instead of requiring array (and thus a major upgrade) since we have no documentation or strict types on our functions/components.
So apps that get the currentUser from d2 (like DV) and apps that get currentUser from dataEngine(like LL) will both work.
Maybe support for Set can be removed in a future major release.