feat: update interpretations component so it can be used in dashboard items #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
As discussed on Slack, it would be good to add some comments and/or rename some variable in src/components/Interpretations/common/Interpretation/Interpretation.js for clarification. But the underlying logic is sound and the implementation is clean. So I'm approving.
…/analytics into feat/interpretations-for-dashboard
…s to not be visible
jenniferarnesen
changed the title
…/analytics into feat/interpretations-for-dashboard
dhis2-bot
added a commit
that referenced
this pull request
Mar 4, 2024
# [26.4.0](v26.3.1...v26.4.0) (2024-03-04) ### Features * update interpretations component so it can be used in dashboard items ([#1510](#1510)) ([163abf6](163abf6))
|
🎉 This PR is included in version 26.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-15441
Required for dhis2/dashboard-app#2430
Changes to the interpretation component so that it can be used in the dashboard app. The main difference between interpretations in dashboard vs DV/LL is that replies are viewed "inline" rather than through opening a modal. In order to add this functionality, the
appUrlproperty is sent from the dashboard app, so that a "Launch Url" button can be added to the interpretation button strip. The button opens the relevant app in interpretation view mode.The component will continue to work as before for DV and LL so this is safe as a "feat" release.
The
appUrlproperty is kind of doing double dutySee interpretationbutton (screenshot from DV)See interpretationbig button)TODO