ci: update workflows #401
Merged
ci: update workflows #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-401--dhis2-data-entry.netlify.app |
tomzemp
approved these changes
Oct 3, 2024
| if: '!github.event.push.repository.fork' | ||
| secrets: inherit | ||
| with: | ||
| api_version: 41 |
There was a problem hiding this comment.
should this be 42 at this point?
There was a problem hiding this comment.
Probably yes. But I think we can do that separately. It means rerecording the fixtures and updating the api version here and in the cypress config.
Mohammer5
approved these changes
Oct 3, 2024
ismay
force-pushed
the
update-workflows
branch
from
2f62adb to
a56f9f5
Compare
|
🎉 This PR is included in version 100.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dhis2.atlassian.net/browse/CLI-71
This app had a unique cypress setup. I've moved it to use the same setup as our other platform apps. That meant:
I can imagine that the removal of the custom reporter would be controversial to some. We currently don't use it in any of our (team platform) other apps, from what I've seen thus far. We could add it back, but since our workflows logic is now centralized, when we add it back we should probably add it back for all apps instead of just this one. Or add it conditionally at the cost of extra complexity. Since the workflows were blocking Tom's work I propose we remove it for now and add it back properly if we all feel it's worth the added complexity (and if we're not blocking any requirements from any other teams, etc.).