fix(integer validation): limit range to the accepted range of the dhis2-core

[Mohammer5]

Fixes DHIS2-14075

Doc comment from is-integer.js:

 * The `integer` validator of the `@dhis2/ui` library uses
 * `Number.isSafeInterger` to assess whether it the value is a valid integer or
 * not. The range allowed by that methid is -(2^53 - 1) to 2^53 - 1.
 *
 * The `isInteger` validator in the Java core uses the `isValid` method of
 * apache's `IntegerValidator` class (see
 * `dhis-2/dhis-support/dhis-support-system/src/main/java/org/hisp/dhis/system/util/MathUtils.java`),
 * which allows an integer range from
 * -2147483648 to 2147483647.
 *
 * This validator re-uses `@dhis2/ui`'s validator but restricts the integer to
 * the range allowed by the Java core.
 */```

[DHIS2-14075]: https://dhis2.atlassian.net/browse/DHIS2-14075?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

[dhis2-bot]

🚀 Deployed on https://pr-364--dhis2-data-entry.netlify.app

[tomzemp]

Approach looks good. I'm not sure the check is working totally as intended (see comments).

Two other things I noticed (not related to your changes):

• I tried testing with an existing data element of type INTEGER (BCG Doses Given, which is on Child Health data set) (https://debug.dhis2.org/dev/api/dataElements/s46m5MS0hxu), and there it seemed like any negative values were being rejected by the backend 🤔
• it seems all validations are rerunning any time any value in the form changes. I guess the validation checks aren't very intensive, but that seems like we wouldn't want that?

[Birkbjo]

Note that this touches code that was changed in: #357

[Mohammer5]

@Birkbjo interesting! I assume min-max limits are also constrained by the BE's integer validation, but that's just an uneducated guess. Do you know @stian-sandvold?

[stian-sandvold]

@Birkbjo interesting! I assume min-max limits are also constrained by the BE's integer validation, but that's just an uneducated guess. Do you know @stian-sandvold?

I don't think we validate those numbers anywhere, but we do store them as ints.

[tomzemp]

looks good!

[Mohammer5]

@Birkbjo: confirmed by @stian-sandvold: We can assume that min-max limits also adhere to the integer range restrictions

[dhis2-bot]

🎉 This PR is included in version 100.3.9 🎉

The release is available on:

• AppHub release
• GitHub release

Your semantic-release bot 📦🚀