fix: prevent stale cached values from loading as initial vals

dhis2 · Dec 20, 2024 · d6dab34 · d6dab34
1 parent de622f2
commit d6dab34
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/data-workspace/data-workspace.js b/src/data-workspace/data-workspace.js
@@ -81,7 +81,11 @@ export const DataWorkspace = ({ selectionHasNoFormMessage }) => {
 
     // We want to block initialization of form if in-flight
     // or else we might use stale data that won't be updated once request completes
-    if (initialDataValuesFetch.isFetching) {
+    if (
+        initialDataValuesFetch.isFetching ||
+        (!initialDataValuesFetch.isFetchedAfterMount &&
+            !initialDataValuesFetch.isPaused)
+    ) {
         return (
             <CenteredContent>
                 <CircularLoader />

diff --git a/src/data-workspace/form-wrapper.js b/src/data-workspace/form-wrapper.js
@@ -1,5 +1,5 @@
 import PropTypes from 'prop-types'
-import React, { useLayoutEffect, useState } from 'react'
+import React, { useEffect, useState } from 'react'
 import { useValueStore } from '../shared/index.js'
 
 function mapObject(input, callback) {
@@ -35,7 +35,7 @@ export function FormWrapper({ children, dataValueSet, validFormKey }) {
         useValueStore((state) => state.getInitialDataValues())?.formKey ===
         validFormKey
 
-    useLayoutEffect(() => {
+    useEffect(() => {
         if (setInitialDataValues && initialValues && validFormKey) {
             setInitialDataValues(initialValues, validFormKey)
         }