This repository has been archived by the owner on Jun 3, 2022. It is now read-only.
Add checkpointFile property to aws_kinesis_config and fix its behavior to apply custom properties #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2017 16:59
* Add checkpointFile property to aws_kinesis_config resource * Add rubocop statement to disable CyclomaticComplexity * Fix aws_kinesis_config resource to apply a default property value only if a custom one is not set
|
@dgoradia any comments on this regard? |
|
@dgoradia any comments? Looking forward to have this option available. |
|
any comments @dgoradia? any chance this will be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the property
checkpoint_filegiving the possibility to change its default path as defined here: https://github.com/awslabs/amazon-kinesis-agent/blob/807ed633f6b95245f058058278d7139221f5d7d8/src/com/amazon/kinesis/streaming/agent/config/AgentConfiguration.java#L27.Additionally, it fixes few properties' behavior of the same resource since they were not supporting custom values.
I bumped the version number but i'm not sure it matches your versioning plan, but if desired I can add another commit that adjusts the version number.