use TODO and comments instead of quietly removing rule-breaking code

dgirardi · Jul 1, 2024 · 5973d8f · 5973d8f
1 parent c8303aa
commit 5973d8f
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 10 deletions.
diff --git a/modules/contxtfulRtdProvider.js b/modules/contxtfulRtdProvider.js
@@ -36,8 +36,28 @@ function getRxEngineReceptivity(requester) {
 }
 
 function loadSessionReceptivity(requester) {
-  return null;
-};
+  // TODO: commented out because of rule violations
+  /*
+  let sessionStorageValue = sessionStorage.getItem(requester);
+  if (!sessionStorageValue) {
+    return null;
+  }
+
+  try {
+    // Check expiration of the cached value
+    let sessionStorageReceptivity = JSON.parse(sessionStorageValue);
+    let expiration = parseInt(sessionStorageReceptivity?.exp);
+    if (expiration < new Date().getTime()) {
+      return null;
+    }
+
+    let rx = sessionStorageReceptivity?.rx;
+    return rx;
+  } catch {
+    return null;
+  }
+   */
+}
 
 /**
  * Prepare a receptivity batch

diff --git a/modules/fintezaAnalyticsAdapter.js b/modules/fintezaAnalyticsAdapter.js
@@ -68,7 +68,13 @@ function initFirstVisit() {
   let now;
   let visitDate;
   let cookies;
-  cookies = {};
+
+  try {
+    // TODO: commented out because of rule violations
+    cookies = {} // parseCookies(document.cookie);
+  } catch (a) {
+    cookies = {};
+  }
 
   visitDate = cookies[ FIRST_VISIT_DATE ];
 
@@ -86,6 +92,7 @@ function initFirstVisit() {
 
   return visitDate;
 }
+// TODO: commented out because of rule violations
 /*
 function trim(string) {
   if (string.trim) {
@@ -167,7 +174,12 @@ function initSession() {
   let sessionDuration;
   let isNew = false;
 
-  cookies = {};
+  try {
+    // TODO: commented out because of rule violations
+    cookies = {} // parseCookies(document.cookie);
+  } catch (a) {
+    cookies = {};
+  }
 
   sessionId = cookies[ SESSION_ID ];
 
@@ -255,7 +267,8 @@ function getTrackRequestLastTime() {
       );
     }
 
-    cookie = {};
+    // TODO: commented out because of rule violations
+    cookie = {} // parseCookies(document.cookie);
     cookie = cookie[ TRACK_TIME_KEY ];
     if (cookie) {
       return parseInt(cookie, 10);

diff --git a/modules/relevatehealthBidAdapter.js b/modules/relevatehealthBidAdapter.js
@@ -142,7 +142,8 @@ function buildUser(bid) {
   if (bid && bid.params) {
     return {
       id: bid.params.user_id && typeof bid.params.user_id == 'string' ? bid.params.user_id : '',
-      buyeruid: '',
+      // TODO: commented out because of rule violations
+      buyeruid: '', // localStorage.getItem('adx_profile_guid') ? localStorage.getItem('adx_profile_guid') : '',
       keywords: bid.params.keywords && typeof bid.params.keywords == 'string' ? bid.params.keywords : '',
       customdata: bid.params.customdata && typeof bid.params.customdata == 'string' ? bid.params.customdata : ''
     };

diff --git a/test/spec/modules/contxtfulRtdProvider_spec.js b/test/spec/modules/contxtfulRtdProvider_spec.js
@@ -322,19 +322,22 @@ describe('contxtfulRtdProvider', function () {
     ];
 
     theories.forEach(([adUnits, expected, _description]) => {
-      it('does not use non-expired info from session storage and adds receptivity to the ad units using session storage', function (done) {
+      // TODO: commented out because of rule violations
+      /*
+      it('uses non-expired info from session storage and adds receptivity to the ad units using session storage', function (done) {
         let config = buildInitConfig(VERSION, CUSTOMER);
         // Simulate that there was a write to sessionStorage in the past.
         writeToStorage(config.params.customer, +100);
         contxtfulSubmodule.init(config);
 
         setTimeout(() => {
-          expect(contxtfulSubmodule.getTargetingData(adUnits, config)).to.not.equal(
+          expect(contxtfulSubmodule.getTargetingData(adUnits, config)).to.deep.equal(
             expected
           );
           done();
         }, TIMEOUT);
       });
+       */
     });
   });
 
@@ -453,7 +456,9 @@ describe('contxtfulRtdProvider', function () {
   });
 
   describe('getBidRequestData', function () {
-    it('does not use non-expired info from session storage and adds receptivity to the reqBidsConfigObj', function (done) {
+    // TODO: commented out because of rule violations
+    /*
+    it('uses non-expired info from session storage and adds receptivity to the reqBidsConfigObj', function (done) {
       let config = buildInitConfig(VERSION, CUSTOMER);
       // Simulate that there was a write to sessionStorage in the past.
       writeToStorage(config.params.bidders[0], +100);
@@ -489,10 +494,11 @@ describe('contxtfulRtdProvider', function () {
         const noOp = () => undefined;
         contxtfulSubmodule.getBidRequestData(reqBidsConfigObj, noOp, buildInitConfig(VERSION, CUSTOMER));
         let actualOrtb2 = reqBidsConfigObj.ortb2Fragments.bidder[config.params.bidders[0]];
-        expect(actualOrtb2).to.not.equal(expectedOrtb2);
+        expect(actualOrtb2).to.deep.equal(expectedOrtb2);
         done();
       }, TIMEOUT);
     });
+     */
   });
 
   describe('getBidRequestData', function () {