Skip to content

Commit

Permalink
CI Fix (#240)
Browse files Browse the repository at this point in the history
* Tweaks CI to new bash defaults

* Updates day which the 3.4 was released

* Removes mamba-version in CI as miniconda merge mamaba

* Fixes linting as well
  • Loading branch information
dgasmith authored Sep 26, 2024
1 parent c15aec2 commit 384bb5a
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 17 deletions.
19 changes: 8 additions & 11 deletions .github/workflows/Linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,35 +16,32 @@ jobs:
environment: ["min-deps"]

runs-on: ubuntu-latest
defaults:
run:
shell: bash -el {0}

steps:
- uses: actions/checkout@v4

- uses: conda-incubator/setup-miniconda@v3
with:
python-version: ${{ matrix.python-version }}
mamba-version: "*"
channel-priority: true
activate-environment: test
environment-file: devtools/conda-envs/${{ matrix.environment }}-environment.yaml

- name: Environment Information
shell: bash -l {0}
run: |
conda info
conda list
conda config --show-sources
conda config --show
- name: Install
shell: bash -l {0}
run: |
python -m pip install . --no-deps
run: python -m pip install . --no-deps

- name: MyPy
shell: bash -l {0}
run: |
mypy opt_einsum
run: mypy opt_einsum

ruff:
name: Ruff
Expand All @@ -55,28 +52,28 @@ jobs:
environment: ["min-deps"]

runs-on: ubuntu-latest
defaults:
run:
shell: bash -el {0}

steps:
- uses: actions/checkout@v2

- uses: conda-incubator/setup-miniconda@v3
with:
python-version: ${{ matrix.python-version }}
mamba-version: "*"
channel-priority: true
activate-environment: test
environment-file: devtools/conda-envs/${{ matrix.environment }}-environment.yaml

- name: Environment Information
shell: bash -l {0}
run: |
conda info
conda list
conda config --show-sources
conda config --show
- name: Lint
shell: bash -l {0}
run: |
set -e
make format-check
8 changes: 3 additions & 5 deletions .github/workflows/Tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,21 @@ jobs:
environment: "torch-only"

runs-on: ubuntu-latest
defaults:
run:
shell: bash -el {0}

steps:
- uses: actions/checkout@v4

- uses: conda-incubator/setup-miniconda@v3
with:
python-version: ${{ matrix.python-version }}
mamba-version: "*"
channel-priority: true
activate-environment: test
environment-file: devtools/conda-envs/${{ matrix.environment }}-environment.yaml

- name: Environment Information
shell: bash -l {0}
run: |
conda info
conda list
Expand All @@ -51,17 +52,14 @@ jobs:
python devtools/ci_scripts/check_no_numpy.py
- name: Install
shell: bash -l {0}
run: |
python -m pip install . --no-deps
- name: Test
shell: bash -l {0}
run: |
pytest -v --cov=opt_einsum opt_einsum/ --cov-report=xml
- name: Coverage
shell: bash -l {0}
run: |
coverage report
Expand Down
2 changes: 1 addition & 1 deletion docs/changelog.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Changelog
=========

## 3.4.0 / 2024-09-XX
## 3.4.0 / 2024-09-26

NumPy has been removed from `opt_einsum` as a dependency allowing for more flexible installs.

Expand Down

0 comments on commit 384bb5a

Please sign in to comment.