Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New "Missing rewards" neuron tag #5920

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

New "Missing rewards" neuron tag #5920

wants to merge 5 commits into from
+65 −0

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Dec 4, 2024 •
edited
Loading

Motivation

Users should be notified about neurons that are losing rewards. For these neurons, a "Missing Rewards" tag should be displayed.

Note: This feature should be behind a flag. The "Losing Soon" tag will be added in a separate PR.

Changes

  • Make getNeuronTags function to return new tag data.

Tests

  • Updated.

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@mstrasinskis mstrasinskis marked this pull request as ready for review December 4, 2024 14:47
@mstrasinskis mstrasinskis requested a review from a team as a code owner December 4, 2024 14:47
@mstrasinskis mstrasinskis changed the title Add missing rewards tag New "Missing rewards" tag Dec 4, 2024
@mstrasinskis mstrasinskis changed the title New "Missing rewards" tag New "Missing rewards" neuron tag Dec 4, 2024
yhabib
yhabib approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabib yhabib yhabib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mstrasinskis @yhabib @gix-bot