Losing rewards neuron card #5909
Merged
+248
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrasinskis
commented
Dec 4, 2024
frontend/src/lib/components/neuron-detail/NeuronFollowingCard/Followee.svelte
Show resolved
Hide resolved
dskloetd
approved these changes
Dec 4, 2024
frontend/src/tests/page-objects/NnsLosingRewardsNeuronCard.page-object.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For the confirm following modal, we need to display inactive neurons with it's following. Here we add a neuron list item component that later will be used.
Note: In a later PR, the style of the Followee component will be slightly adjusted.
Changes
Tests
Refactor FolloweePo to return the same title for active and inactive components.
Added NnsLosingRewardsNeuronCardPo.
Added test for NnsLosingRewardsNeuronCard.
Tested locally in another branch.
Todos
Not necessary.