Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiP: Imported tokens form #5256

Draft
wants to merge 172 commits into
base: main
Choose a base branch
from
Draft

WiP: Imported tokens form #5256

wants to merge 172 commits into from
+1,332 −132

Conversation

mstrasinskis
Copy link
Contributor

Motivation

Changes

Tests

Todos

  • Add entry to changelog (if necessary).

mstrasinskis and others added 30 commits July 28, 2024 10:44
@mstrasinskis
New const MAX_IMPORTED_TOKENS
40488ec
@mstrasinskis
New imported tokens services
c79717e
@mstrasinskis
Comments
da6ad8f
@mstrasinskis
refactro: addImportedToken
503c294
@mstrasinskis
Test loadImportedTokens
ef1593b
@mstrasinskis
refactor: error messages
015346f
@mstrasinskis
refactor: testError
3d49dee
@mstrasinskis
Test addImportedToken
1e36698
@mstrasinskis
refactor: split addImportedToken
09e3c30
@mstrasinskis
New removeImportedToken service
2740b47
@mstrasinskis
refactor: error/success messages
91c476d
@mstrasinskis
test success toast
c913361
@mstrasinskis
Test removeImportedToken
c679bde
@mstrasinskis
Merge branch 'main' into mstr/imported-tokens-services
ed0ea9d
@mstrasinskis
Fix typo
9af3859
@mstrasinskis
Comments
2fa54de
@mstrasinskis
Merge branch 'mstr/imported-tokens-services' of https://github.com/df…
7a390f4 
…inity/nns-dapp into mstr/imported-tokens-services
@mstrasinskis
Todo added
70cece1
@mstrasinskis
Add ImportTokenWarning
a3bc1da
@mstrasinskis
Prop "required" for PrincipalInput
0b30654
@mstrasinskis
New labels
c97d4e3 
# Conflicts:
#	frontend/src/lib/i18n/en.json
@mstrasinskis
ImportTokenForm component base
57dce25
@mstrasinskis
Dispatch nnsSubmit from ImportTokenForm
f8fa6c5
@mstrasinskis
New ImportTokenModal component with basic validation
a0c299f
@mstrasinskis
Add import-token-validation busy initiator type
ca474b3
@mstrasinskis
Busy screen text
fdf850e
@mstrasinskis
Add LinkIcon component
aa4e143
@mstrasinskis
Add ImportTokenCanisterId component
594c776
@mstrasinskis
Add ImportTokenReview component
f1064ea
@mstrasinskis
Change index_label_optional label
58941d8
@mstrasinskis
Restore missing label
3ad601f
@mstrasinskis
Merge remote-tracking branch 'origin/main' into mstr/imported-tokens-…
59f91a3 
…form
@mstrasinskis
Safari table fix - Squashed commit of the following:
eb4b947 
commit 3fa7e3f
Author: Max Strasinsky <[email protected]>
Date:   Thu Aug 15 14:01:08 2024 +0200

    Changelog

commit 592830e
Author: Max Strasinsky <[email protected]>
Date:   Thu Aug 15 13:36:49 2024 +0200

    Attempt to fix safari table glitch
@mstrasinskis
Formatting
17da1cd
@mstrasinskis
cleanup: remove unused vars
05f6380
@mstrasinskis
Add remove button to the more popup
723dbc5
@mstrasinskis
style: "more" popup buttons
ae1ed05
@mstrasinskis
style: Import button redesign
fb9907d
@mstrasinskis
cleanup
8ac4efe
@mstrasinskis
feat: remove imported token confirmation dialog (ImportTokenRemoveCon…
ced1d8b 
…firmation)
@mstrasinskis
Formatting
10cf9ce
@mstrasinskis
Fix type warnings
7e1cf6b
@mstrasinskis
Fix type warnings
f9011dd
@mstrasinskis
Remove redundant lables
9efce2c
@mstrasinskis
Merge branch 'main' into mstr/imported-tokens-form
87042ae
@mstrasinskis
Fix loading imported tokens before the NNS account was created.
9ddec40
@mstrasinskis
Revert "style: Import button redesign"
246e65c 
This reverts commit fb9907d.
@mstrasinskis
Adjust ImportTokenCanisterId.spec to new sub components
037c598
@mstrasinskis
test: should not show import token button when they are not loaded
3923923
@mstrasinskis
Fix outdated specs
87f9cd1
@mstrasinskis
Merge branch 'main' into mstr/imported-tokens-form
8d93ac9
@mstrasinskis
Move IMPORTANT_CK_TOKEN_IDS to tokens constant
6bba91d
@mstrasinskis
Replace isUniqueImportedToken with isImportedToken
82903ce
@mstrasinskis
test: isImportedToken
9c016de
@mstrasinskis
Merge branch 'main' into mstr/imported-tokens-form
43778c4 
# Conflicts:
#	frontend/src/lib/components/accounts/WalletPageHeader.svelte
#	frontend/src/lib/i18n/en.json
#	frontend/src/lib/pages/NnsWallet.svelte
#	frontend/src/lib/types/i18n.d.ts
#	frontend/src/tests/lib/pages/NnsWallet.spec.ts
#	frontend/src/tests/page-objects/NnsWallet.page-object.ts
@mstrasinskis
style: update remove confirmation styles
b31156b
@mstrasinskis
Cleanup RemoveConfirmation component
1b51c1c
@mstrasinskis
test: ImportTokenRemoveConfirmation
8d031bd
@mstrasinskis
Squashed commit of the following:
45d5a8b 
commit 2acd2fd
Author: Max Strasinsky <[email protected]>
Date:   Tue Aug 27 11:57:53 2024 +0200

    Use ConfirmationModal for ImportTokenRemoveConfirmation

commit 19f982a
Author: Max Strasinsky <[email protected]>
Date:   Tue Aug 27 11:57:27 2024 +0200

    Add optional labels support to ConfirmationModal.svelte

commit d38fa0a
Author: Max Strasinsky <[email protected]>
Date:   Mon Aug 26 17:03:44 2024 +0200

    Update imports

commit 3d8fc9e
Author: Max Strasinsky <[email protected]>
Date:   Mon Aug 26 16:51:29 2024 +0200

    Remove testing of the static description

commit 0f244fa
Author: Max Strasinsky <[email protected]>
Date:   Mon Aug 26 16:51:08 2024 +0200

    Split remove_confirmation_description into 2 messages

commit 25fa501
Author: Max Strasinsky <[email protected]>
Date:   Mon Aug 26 16:35:38 2024 +0200

    Provide universe instead of ledgerCanisterId to the ImportTokenRemoveConfirmation component

commit 3a935ba
Author: Max Strasinsky <[email protected]>
Date:   Mon Aug 26 16:34:24 2024 +0200

    Use cancel label for cancel button

commit 85e2686
Author: Max Strasinsky <[email protected]>
Date:   Fri Aug 23 15:31:24 2024 +0200

    Formatting

commit 38d5c58
Author: Max Strasinsky <[email protected]>
Date:   Fri Aug 23 14:46:31 2024 +0200

    Add missing label

commit 00b82c3
Author: Max Strasinsky <[email protected]>
Date:   Fri Aug 23 14:37:37 2024 +0200

    test: ImportTokenRemoveConfirmation

commit 454b4c4
Author: Max Strasinsky <[email protected]>
Date:   Fri Aug 23 14:37:32 2024 +0200

    New ImportTokenRemoveConfirmation component

commit 699e9b6
Author: David de Kloet <[email protected]>
Date:   Fri Aug 23 08:59:21 2024 +0200

    Update SNS aggregator changelog for proposal 129614 (#5346)

    # Motivation

    We forgot to update the SNS aggregator changelog after the
    [upgrade](https://dashboard.internetcomputer.org/proposal/129614) back
    in May.

    # Changes

    Move the entries that were already there before the previous upgrade, to
    a separate section.

    I also updated the release SOP for the aggregator to include an item
    about the changelog.

    # Tests

    n/a

    # Todos

    - [x] Add entry to changelog (if necessary).

commit 00d108b
Author: sa-github-api <[email protected]>
Date:   Fri Aug 23 01:47:17 2024 -0500

    bot: Update snsdemo to release-2024-08-21 (#5345)

    # Motivation
    We would like to keep the testing environment, provided by snsdemo, up
    to date.

    # Changes
    * Updated `snsdemo` version in `dfx.json`.
    * Ensured that the `dfx` version in `dfx.json` matches `snsdemo`.

    # Tests
    CI should pass.

    Co-authored-by: gix-bot <[email protected]>
@mstrasinskis
Adjustments for refactored ImportTokenRemoveConfirmation
e54847f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mstrasinskis