feat(nns): Move spawn_neurons to a one-minute timer #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-dfinity
approved these changes
Dec 3, 2024
max-dfinity
reviewed
Dec 3, 2024
jasonz-dfinity
force-pushed
the
jason/spawn-neurons-in-timer
branch
from
691075f
to
04e4760
Compare
jasonz-dfinity
force-pushed
the
jason/spawn-neurons-in-timer
branch
from
04e4760
to
71e9ecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As we plan to move neurons to stable storage, the cost for scanning neurons to spawn will increase (80x). Therefore, to keep the average instruction count similar, we reduce its frequency (twice per second -> once every minute)
What
maybe_spawn_neurons()every minutespawn_neuronsfrom heartbeatTests
Verified that
bazel test //rs/nns/integration_tests:integration_tests_test_src/governance_neurons --test_filter=test_spawn_neuronfails if thespawn_neuronsis removed from heartbeat but not added to timer