Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nns): Add new ProposalRewardStatus to handle async vote processing #2931

Closed
wants to merge 1 commit into from
Closed

feat(nns): Add new ProposalRewardStatus to handle async vote processing #2931

wants to merge 1 commit into from

Conversation

max-dfinity
Copy link
Contributor

This adds a new status that will be used with async rewards processing (i.e. being able to have following happen after the voting deadline in a message, while still not being able to register new votes).

@github-actions github-actions bot added the feat label Dec 2, 2024
@max-dfinity max-dfinity marked this pull request as ready for review December 2, 2024 23:17
@max-dfinity max-dfinity requested a review from a team as a code owner December 2, 2024 23:17
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-I branch from 49fe21f to 4da5882 Compare December 2, 2024 23:33
@max-dfinity max-dfinity requested review from a team as code owners December 2, 2024 23:33
Base automatically changed from msum/stable-neuron-support-H to master December 2, 2024 23:39
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-I branch from 4da5882 to 7a82f34 Compare December 2, 2024 23:55
@max-dfinity max-dfinity enabled auto-merge December 2, 2024 23:56
@max-dfinity max-dfinity disabled auto-merge December 2, 2024 23:56
@frankdavid
Copy link
Contributor

Hey, why do you need the node team's approval for this change?

@max-dfinity
Copy link
Contributor Author

@frankdavid I don't - I'm not sure why it tagged all these teams....

@max-dfinity max-dfinity removed request for a team December 3, 2024 00:28
@max-dfinity max-dfinity removed request for a team December 3, 2024 00:28
@marko-k0
Copy link
Member

marko-k0 commented Dec 3, 2024

@frankdavid I don't - I'm not sure why it tagged all these teams....

GitHub's API response was from a previous change set (suggesting that the new diff was not yet accounted by GitHub) and it seems that our workflow doesn't handle the scenario where PR is in ready state and you're doing a force push. Probably we should only trigger our workflow when the CI completes and is green. GitHub's API would probably give the right response at that time.

@max-dfinity
Copy link
Contributor Author

Thanks @marko-k0 - I wasn't aware of that bad push in the middle there - I must have had some intermittent issue with my git repository locally.

@max-dfinity
Copy link
Contributor Author

No longer need this, taking different approach

@max-dfinity max-dfinity closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonz-dfinity jasonz-dfinity jasonz-dfinity approved these changes

Assignees
No one assigned
Labels
feat @nns-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@max-dfinity @frankdavid @marko-k0 @jasonz-dfinity