chore: Add dfx-core dependency #2927
Draft
+7,291
−1,212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Andre, I don't understand the purpose of this PR. Why add a dependency on an external crate if it's not being used internally? |
My intention is to use it in the implementation of the SNS DFX Extension, which is in the monorepo. But I'm marking the PR as draft because to do this we may actually need to update a couple other dependencies as well. |
anchpop
force-pushed
the
@anchppo/dfx-core-dep
branch
from
f727b58
to
35f9a90
Compare
anchpop
force-pushed
the
@anchppo/dfx-core-dep
branch
2 times, most recently
from
0a2b18b
to
1ff2748
Compare
anchpop
force-pushed
the
@anchppo/dfx-core-dep
branch
from
1ff2748
to
6be5355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the DFX SNS extension to better integrate with DFX. The dependency is maintained by DFINITY, it is just not part of the monrepo (and not currently depended on by the monorepo, prior to this PR).
dfx-core uses a newer version of ic-agent, which means we need to update ic-agent in the monorepo, and that means we need to update ic-http-gateway (which I do here).